Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements JSON output support for the MinVer CLI tool, allowing users to retrieve version information in machine-readable JSON format alongside the existing text format.
Key Changes:
- Added
--formatCLI argument to support both text and JSON output formats - Made core data structures serializable by adding
serde::Serializederive macros - Implemented JSON formatting that includes all version components and calculation metadata
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/core/src/version.rs | Added Serialize derive to Version struct for JSON serialization support |
| crates/core/src/lib.rs | Added Serialize derive to CalculationResult struct for JSON output |
| crates/core/Cargo.toml | Added serde dependency with derive features |
| crates/cli/src/main.rs | Implemented OutputFormat enum and JSON output logic with format selection |
| crates/cli/Cargo.toml | Added serde_json and serde dependencies for JSON serialization |
| crates/cli/tests/cli.rs | Added integration test verifying JSON output format and content |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.