feat(phase7): dispatch pipeline, file writing, requeue, PR#28 review fixes

[screenleon]

Summary

• Dispatch pipeline (connector/service.go): full task-claim → execute → submit loop with progress ticker and file-writing support
• Migration 035: backfill project_members for existing projects so FK constraints are satisfied post-migration
• Requeue (RequeueDispatch): task store method + handler wired to POST /api/tasks/:id/requeue-dispatch
• File writing: connector submit result now handles files[] as path-objects or strings; files_applied count displayed in dispatch badge
• PR feat(phase6c+phase3b): LLM router, activity SSE, context pack v2, evidence panel #28 review fixes (all blocking/critical + all 5 Copilot comments):
  • B1: Fixed send-on-closed-channel panic in activity/Hub.Update() — removed close(c) from unsub()
  • B2: SSE per-user cap (max 3) via SubscribeWithCap(connectorID, userID)
  • B3: Idle activity purge after 5 min via Hub.StartPurge(ctx)
  • B4: Reasoning sanitization in connector/suggest.go (≤1024 chars, strip control chars)
  • B5: suggest_role_test.go — 4 new handler tests covering 503/404/200+error/200+success cases
  • C1: SuggestRole always returns HTTP 200 (advisory endpoint per API-008)
  • C2: fetched.current = true set only after successful context snapshot fetch
  • C3: computeQualitySummary errors now logged instead of silently discarded
  • C4: ListActive validates project exists before listing connectors
  • C5: useConnectorActivity only starts polling in SSE onerror fallback

Test plan

• go test ./internal/activity/... ./internal/handlers/... — all pass
• go build ./... — no compile errors
• Connector pairs, heartbeats, and dispatch cycle works end-to-end in local mode
• SSE stream for connector activity connects and updates; 4th concurrent connection returns 503
• Idle connector activity entries purge after 5 min
• POST /api/backlog-candidates/:id/suggest-role returns HTTP 200 always (error in body on failure)
• Dispatch badge shows "N files applied" when files_applied is in execution result
• Context drawer retries on transient fetch error (fetched.current not set on failure)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Implements Phase 6c/7 end-to-end improvements across backend + connector + frontend, including connector activity visibility (SSE + polling fallback), advisory role suggestion, planning context snapshot retrieval UI, and dispatch retry tooling; also updates CI/pre-PR scripts and governance rules to support faster validation.

Changes:

• Adds connector activity reporting + persistence + SSE endpoints, plus frontend badge/hook to display real-time connector phase.
• Adds planning context snapshot storage/retrieval (context.v2) and a frontend drawer to inspect snapshot metadata on completed runs.
• Adds task dispatch requeue endpoint + UI retry affordance, plus a “test affected” workflow and CI path-based job skipping.

Reviewed changes

Copilot reviewed 88 out of 88 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
scripts/test-affected.sh	New script to run backend Go tests for changed pkgs + reverse deps.
scripts/pre-pr-check.sh	Adds “--fast” mode to run affected-only frontend/backend tests.
rules/global/core.md	Strengthens global agent rules (ambiguity handling, scope control, test-first bugfix).
rules/domain/frontend-components.md	Adds UI-007 (SSE fan-out bus) + UI-008 (advisory UI must require confirmation).
rules/domain/backend-api.md	Adds API-007 (SSE payload routing fields) + API-008 (advisory endpoints always 200).
go.work.sum	Adds Go workspace sum entries.
frontend/src/types/index.ts	Adds connector activity types, context snapshot types, quality summary, feedback fields, dashboard summary fields.
frontend/src/pages/ProjectDetail/planning/hooks/usePlanningWorkspaceData.ts	Wires suggest-role + feedback submit handlers; reacts to planning-run-changed window events.
frontend/src/pages/ProjectDetail/planning/PlanningRunList.tsx	Shows activity badge for active runs; adds quality summary row; adds context snapshot drawer.
frontend/src/pages/ProjectDetail/planning/PlanningRunContextDrawer.tsx	New lazy-loaded context snapshot drawer component.
frontend/src/pages/ProjectDetail/TasksTab.tsx	Parses execution_result files/files_applied; adds requeue “Retry” button for failed role_dispatch tasks.
frontend/src/pages/ProjectDetail/ProjectOverviewTab.tsx	Displays 7-day planning acceptance rate summary when available.
frontend/src/pages/ProjectDetail/PlanningTab.tsx	Plumbs role suggestion + feedback submit callbacks into candidate review panel(s).
frontend/src/pages/ProjectDetail.tsx	Passes dashboard summary acceptance-rate fields into overview tab.
frontend/src/hooks/useConnectorActivity.ts	New hook for connector activity via SSE + polling fallback.
frontend/src/components/ConnectorActivityBadge.tsx	New badge component for connector activity display.
frontend/src/api/client.ts	Adds client methods for requeue dispatch, suggest-role, context snapshot, connector activity endpoints.
frontend/src/App.tsx	Fans out planning-run-changed SSE events via window CustomEvent bus.
frontend/package.json	Adds test:affected script (vitest run --changed).
docs/rules-quickstart.md	Updates quickstart checklist to reflect new GLOBAL-* rules.
docs/phase6c-dogfood-notes.md	Adds dogfood run template/checklist for Phase 6c.
docs/phase3a-spike-findings.md	Adds Phase 3A feasibility findings + recommended roadmap.
docs/operating-rules.md	Adds role-dispatch safety/visibility model; updates scope control + bugfix test-first guidance.
docs/data-model.md	Updates migration “current applied” marker; documents connector activity + context snapshot tables/fields.
docs/api-surface.md	Documents new endpoints (context snapshot, suggest-role, activity endpoints, requeue dispatch).
backend/internal/store/task_store.go	Adds RequeueDispatchTask to reset failed role_dispatch tasks to queued.
backend/internal/store/summary_store.go	Computes 7-day average planning acceptance rate + reviewed run count.
backend/internal/store/project_store.go	Adds CreateWithOwner to insert project_members row atomically on create.
backend/internal/store/planning_run_store.go	Persists context_pack_id; attaches QualitySummary on GetByID; updates scan/selects.
backend/internal/store/local_connector_store.go	Persists/restores connector activity snapshots (current_activity_json/current_activity_at).
backend/internal/store/context_snapshot_store_test.go	Tests context snapshot save/get + pack_id set on run create.
backend/internal/store/context_snapshot_store.go	New store for planning_context_snapshots table.
backend/internal/store/backlog_candidate_store.go	Adds feedback_kind/note persistence + validation; expands select/scan/update.
backend/internal/store/backlog_candidate_feedback_test.go	Store tests for candidate feedback + quality summary aggregation.
backend/internal/router/router.go	Wires new routes: context snapshot, suggest-role, requeue dispatch, activity endpoints.
backend/internal/roles/catalog_test.go	Updates prompt dir comparison; adds meta prompt file validation test.
backend/internal/roles/catalog.go	Adds meta role dispatcher (CategoryMeta).
backend/internal/prompts/render.go	Embeds meta/*.md prompts in addition to roles.
backend/internal/prompts/meta/dispatcher.md	New dispatcher meta-prompt definition.
backend/internal/planning/wire/context_v2_test.go	Tests context.v2 constants + v1→v2 upgrade behavior.
backend/internal/planning/wire/context_v2.go	Adds PlanningContextV2 envelope + UpgradeV1ToV2 helper.
backend/internal/planning/scale/scale_test.go	Tests task-scale heuristic behavior.
backend/internal/planning/scale/scale.go	Implements task-scale estimation heuristic.
backend/internal/planning/orchestrator.go	Adds SnapshotSaver interface + orchestrator wiring hook.
backend/internal/models/summary.go	Adds dashboard acceptance-rate fields to API model.
backend/internal/models/requirement.go	Adds feedback kinds, quality summary model, context_pack_id + quality_summary on PlanningRun, router_no_match error kind.
backend/internal/models/local_connector.go	Adds connector activity models + ClaimNextRun response includes PlanningContextV2.
backend/internal/handlers/tasks.go	Adds POST requeue-dispatch handler.
backend/internal/handlers/suggest_role_test.go	Handler-level tests for suggest-role advisory contract and error cases.
backend/internal/handlers/projects.go	Ensures project create inserts owner membership via CreateWithOwner.
backend/internal/handlers/planning_runs_context.go	Adds GET context snapshot handler with structured/raw modes.
backend/internal/handlers/planning_runs.go	Adds suggest-role handler + feedback_kind validation + context snapshot store wiring.
backend/internal/handlers/local_connectors.go	Saves context snapshots on ClaimNextRun; publishes planning-run-changed SSE; wires broker + snapshot saver.
backend/internal/handlers/connector_dispatch.go	Adds repo_path to claim-next-task response so connector can apply files.
backend/internal/handlers/connector_activity_test.go	Handler/store tests for activity report + polling/list endpoints.
backend/internal/handlers/connector_activity.go	Adds connector activity ingest + polling + SSE stream + active-connectors list.
backend/internal/handlers/candidate_feedback_test.go	Handler tests for feedback_kind validation on PATCH candidate.
backend/internal/database/database.go	Adds SQLite rewrite for gen_random_uuid() in migrations.
backend/internal/connector/suggest.go	Implements server-side dispatcher meta-prompt execution + output validation/sanitization.
backend/internal/connector/dispatch.go	Adds repo_path to connector-side claim-next-task response DTO.
backend/internal/connector/client.go	Adds client.ReportActivity() for connector.
backend/internal/connector/app.go	Starts ActivityReporter and wires into connector service startup.
backend/internal/connector/activity_reporter.go	Adds async/coalescing activity reporter for connector → server updates.
backend/internal/activity/hub_test.go	Adds tests for hub broadcast, cap, persistence, and concurrency behaviors.
backend/internal/activity/hub.go	Implements in-process activity hub with persistence, SSE cap, idle purge.
backend/db/migrations/035_backfill_project_members.sql	Backfills project_members for existing projects/users (incl local-admin).
backend/db/migrations/035_backfill_project_members.down.sql	No-op down migration.
backend/db/migrations/034_candidate_feedback.sql	Adds feedback_kind + feedback_note columns.
backend/db/migrations/034_candidate_feedback.down.sql	No-op down migration for SQLite compatibility.
backend/db/migrations/033_planning_runs_pack_id.sql	Adds context_pack_id to planning_runs.
backend/db/migrations/033_planning_runs_pack_id.down.sql	No-op down migration.
backend/db/migrations/032_planning_context_snapshots.sql	Adds planning_context_snapshots table + index.
backend/db/migrations/032_planning_context_snapshots.down.sql	Drops planning_context_snapshots table + index.
backend/db/migrations/031_connector_activity.sql	Adds current_activity_json/current_activity_at columns.
backend/db/migrations/031_connector_activity.down.sql	Notes/no-op down guidance.
backend/cmd/server/main.go	Wires context snapshot store, role suggester, activity hub + purge, and SSE broker; ensures local project has owner membership.
Makefile	Adds test-affected targets for backend/frontend.
AGENTS.md	Expands pre-PR gate to include additional reviewer roles.
.github/workflows/ci.yml	Adds path-change detection job and conditional job execution.
.claude/agents/testing-reviewer.md	Adds testing-reviewer agent doc.
.claude/agents/architecture-reviewer.md	Adds architecture-reviewer agent doc.