refactor(cc-203): GROUP-B Batch 4a — migrate test-uninstall + test-dispatch-handover#138
Merged
Conversation
CC-203 GROUP-B Batch 4a (1/2). Harness default format matches original (PASS: $name / FAIL: $name: $detail); no override needed. Collect-all preserved. Pre/post: 23 cases, 23 passed locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…rness CC-203 GROUP-B Batch 4a (2/2). Renamed all t_pass/t_fail callsites to harness pass/fail. Format already matched harness default. run_case helper updated to use should_run gating. Pre/post: 65 cases, 65 passed locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CC-203 GROUP-B Batch 4a of 3 (4b will do test-pr-gate.sh, 4c will do test-hooks.sh alone — split per user preference for fine-grained review on the largest remaining files).
test-uninstall.shtest-dispatch-handover.shNet: −22 lines. Both files had format already matching harness default (
PASS: $name/FAIL: $name: $detail); no overrides needed. Both are collect-all (no fail-fast).Per-file
test-uninstall.sh: clean migration.pass/failhelpers had harness shape already; just sourced harness +th_init/should_runwrapping /th_summaryswap.test-dispatch-handover.sh: renamed allt_pass/t_failcallsites to harnesspass/fail.run_casehelper updated to useshould_rungating. Format already default.Gate result
/pr-gatestandard tier: Final: GO / overall approve — all 3 reviewers (critic + qa-tester + architecture-reviewer) approve with no findings.Cross-file no-regression
bash install.sh --verify— cleanbash scripts/test-run-all-tests.sh— 13/13 passCommits
7920e51— test-uninstall.sh6c957f2— test-dispatch-handover.shTest plan
bash scripts/test-uninstall.sh— 23/23 (was 23)bash scripts/test-dispatch-handover.sh— 65/65 (was 65)bash scripts/lint-scripts.sh— 52 OK--list/--filter/--filter NONEXISTENTper harness contract on both filesbash install.sh --verify— all preflights passshellcheck --severity=style— not installed locally; CI will run it (both files already in exclude list)Remaining for CC-203 closure
🤖 Generated with Claude Code