Skip to content

[codex] fix macOS keyboard layout capture#3366

Merged
louis030195 merged 1 commit into
mainfrom
codex/french-azerty-meeting-feedback
May 13, 2026
Merged

[codex] fix macOS keyboard layout capture#3366
louis030195 merged 1 commit into
mainfrom
codex/french-azerty-meeting-feedback

Conversation

@louis030195
Copy link
Copy Markdown
Collaborator

@louis030195 louis030195 commented May 13, 2026

Summary

  • respect the active macOS keyboard layout when converting captured keycodes into text
  • keep the existing US-keyboard fallback for cases where the macOS layout API is unavailable
  • add focused coverage for the fallback mapping and Carbon modifier conversion

Why

AZERTY users were seeing captured keyboard input interpreted like QWERTY during meetings because macOS text capture used a hard-coded US key map.

Validation

  • cargo check -p screenpipe-a11y
  • cargo test -p screenpipe-a11y keycode_mapping
  • cargo test -p screenpipe-a11y carbon_modifier_state
  • git diff --check

@louis030195 louis030195 force-pushed the codex/french-azerty-meeting-feedback branch from 33e02bf to cbfe26d Compare May 13, 2026 19:51
@louis030195 louis030195 changed the title [codex] improve French meeting notes feedback [codex] fix macOS keyboard layout capture May 13, 2026
@louis030195 louis030195 marked this pull request as ready for review May 13, 2026 20:24
@louis030195 louis030195 merged commit ddfbbf2 into main May 13, 2026
21 of 23 checks passed
@louis030195 louis030195 deleted the codex/french-azerty-meeting-feedback branch May 13, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant