Skip to content

Conversation

@Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Nov 26, 2025

Description

In this PR we are removing the usage of deprecated aws-sdk-go (deprecation announcement).

Most of internal Go services are migrated to aws-sdk-go-v2.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links


Note

Drops aws-sdk-go v1, migrates instrumentation and Kafka MSK IAM auth to aws-sdk-go-v2, removes deprecated APIs, and updates tests/dependencies.

  • Breaking changes:
    • Remove pkg/instrumentation.InstrumentAWSSession and kafka.Config.AwsSession.
  • Instrumentation (AWS):
    • Keep v2-only InstrumentAWSClient using dd-trace v2 middleware; delete v1 session wrapper.
    • Update aws_test.go to use v2 (config, s3, resolver types) and new span/tag expectations.
  • Kafka (MSK IAM SASL):
    • getAwsMskIamSaslOption now accepts only *aws.Config; remove session-based path and helper.
    • Assume role via v2 sts client; adjust imports and calls.
  • Dependencies:
    • Remove github.com/aws/aws-sdk-go v1 and related transitive deps; tidy go.mod/go.sum.

Written by Cursor Bugbot for commit fbee091. This will update automatically on new commits. Configure here.

@Neurostep Neurostep requested a review from a team as a code owner November 26, 2025 10:19
@Neurostep Neurostep requested a review from athtran November 26, 2025 10:19
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Neurostep Neurostep merged commit 7b808c2 into main Nov 26, 2025
8 checks passed
@Neurostep Neurostep deleted the maksimt/DEVPLAT-4317/remove-aws-sdk-v1 branch November 26, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants