Skip to content

[SERF-1384] Add support for cross-account access to secrets #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terranisu merged 3 commits into from
Jan 21, 2022
Merged

[SERF-1384] Add support for cross-account access to secrets #11

terranisu merged 3 commits into from
Jan 21, 2022

Conversation

@terranisu
Copy link
Member

@terranisu terranisu commented Dec 20, 2021 •
edited
Loading

Description

The PR adds support for cross-account access to secrets.

Testing considerations

The changes are backward-compatible. The PR was tested in development and staging environments:

  • For the single-account secrets, no terraform changes.
  • For the cross-account secrets I've verified the steps described in the README and they work as advertised.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@terranisu terranisu self-assigned this Dec 20, 2021
@terranisu terranisu force-pushed the vadimka/support-custom-kms-keys branch 6 times, most recently from 44c0ea6 to c4536f6 Compare December 23, 2021 16:18
@terranisu terranisu force-pushed the vadimka/support-custom-kms-keys branch 2 times, most recently from 74f9096 to 68d061f Compare January 7, 2022 14:43
@terranisu terranisu changed the title WIP: Add support for custom KMS keys [SERF-1384] Add support for cross-account secrets Jan 7, 2022
@terranisu terranisu changed the title [SERF-1384] Add support for cross-account secrets [SERF-1384] Add support for cross-account access to secrets Jan 7, 2022
@terranisu terranisu force-pushed the vadimka/support-custom-kms-keys branch from 68d061f to da88603 Compare January 12, 2022 14:02
@terranisu terranisu marked this pull request as ready for review January 12, 2022 14:02
@terranisu terranisu requested a review from a team as a code owner January 12, 2022 14:02
@terranisu terranisu force-pushed the vadimka/support-custom-kms-keys branch 3 times, most recently from cf41073 to 5191366 Compare January 13, 2022 10:56
@terranisu terranisu force-pushed the vadimka/support-custom-kms-keys branch from 5191366 to c06c540 Compare January 13, 2022 10:56
fotos
fotos approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM ㊙️ 🔏 🚀

Neurostep
Neurostep approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@terranisu terranisu merged commit 9478b48 into main Jan 21, 2022
@terranisu terranisu deleted the vadimka/support-custom-kms-keys branch January 21, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neurostep Neurostep Neurostep approved these changes

@derricksong derricksong Awaiting requested review from derricksong

+1 more reviewer

@fotos fotos fotos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@terranisu terranisu

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terranisu @fotos @Neurostep