Skip to content

Conversation

@terranisu
Copy link
Member

@terranisu terranisu commented Aug 19, 2022

Description

Terraform 0.14 is more strict when it comes to sensitivity-awareness of the input and output variables passed to/from the modules.

The PR marks the secret outputs as sensitive by default. These outputs are already marked as sensitive in many of our modules and cause Terraform 0.14 plans fail with the following error if the secrets are not marked as sensitive across all the module stack:

Error: Output refers to sensitive values

  on .terraform/modules/app.secrets/outputs.tf line 1:
   1: output "all" {

Expressions used in outputs can only refer to sensitive values if the sensitive attribute is true.

Testing considerations

The change has been tested in the internal Terraform 0.14 CI/CD pipelines.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@terranisu terranisu self-assigned this Aug 19, 2022
@terranisu terranisu changed the title Vadimka/mark sensitive outputs [SERF-1846] Mark secrets as sensitive by default Aug 19, 2022
@terranisu terranisu marked this pull request as ready for review August 19, 2022 09:22
@terranisu terranisu requested a review from a team as a code owner August 19, 2022 09:22
@terranisu terranisu requested review from Neurostep and fotos August 19, 2022 09:22
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM ㊙️

@terranisu terranisu merged commit 85face3 into main Aug 19, 2022
@terranisu terranisu deleted the vadimka/mark-sensitive-outputs branch August 19, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants