Skip to content

[PE-5232] Adding SNS topic allow to SQS policy #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HamiltonHord merged 1 commit into from
Jan 31, 2024
Merged

[PE-5232] Adding SNS topic allow to SQS policy #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions autotagging.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ resource "aws_lambda_function" "auto_tagging" {

environment {
variables = {
UNWRAP_SNS_ENVELOPE = var.sns_topic_arn == "" ? false : true
UNWRAP_SNS_ENVELOPE = var.sns_topic_arn == "" ? false : true
}
}

Expand All @@ -37,7 +37,7 @@ resource "aws_sqs_queue" "auto_tagging" {
count = var.enable_auto_tagging == true ? 1 : 0

name = "${var.sqs_queue_name}-auto_tagging"
policy = data.aws_iam_policy_document.auto_tagging_sqs[0].json
policy = var.sns_topic_arn == "" ? data.aws_iam_policy_document.auto_tagging_sqs[0].json : data.aws_iam_policy_document.auto_tagging_sns[0].json
visibility_timeout_seconds = var.sqs_visibility_timeout_seconds
delay_seconds = var.sqs_delay_seconds

Expand Down Expand Up @@ -98,6 +98,26 @@ data "aws_iam_policy_document" "auto_tagging_sqs" {
}
}

data "aws_iam_policy_document" "auto_tagging_sns" {
count = var.sns_topic_arn == "" ? 0 : 1

statement {
effect = "Allow"
principals {
type = ""
identifiers = [""]
}
actions = ["sqs:SendMessage"]
resources = ["arn:aws:sqs:*:*:${var.sqs_queue_name}-auto_tagging", ]
condition {
test = "ArnEquals"
variable = "aws:SourceArn"
values = [var.sns_topic_arn]
}
}

}

data "aws_iam_policy_document" "auto_tagging_sqs_dl" {
count = var.enable_auto_tagging == true ? 1 : 0

Expand Down
23 changes: 22 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ resource "aws_lambda_event_source_mapping" "this_lambda_events" {
resource "aws_sqs_queue" "this_sqs" {
count = local.enable_group_events ? 0 : 1
name = var.sqs_queue_name
policy = data.aws_iam_policy_document.this_sqs_queue_policy_data.json
policy = var.sns_topic_arn == "" ? data.aws_iam_policy_document.this_sqs_queue_policy_data.json : data.aws_iam_policy_document.this_sns_to_sqs[0].json
visibility_timeout_seconds = var.sqs_visibility_timeout_seconds
delay_seconds = var.sqs_delay_seconds
redrive_policy = jsonencode({
Expand Down Expand Up @@ -312,6 +312,27 @@ data "aws_iam_policy_document" "this_sqs_queue_policy_data" {
}
}

data "aws_iam_policy_document" "this_sns_to_sqs" {
count = var.sns_topic_arn == "" ? 0 : 1

statement {
effect = "Allow"
principals {
type = ""
identifiers = [""]
}
actions = ["sqs:SendMessage"]
resources = local.enable_group_events ? ["arn:aws:sqs:*:*:${var.sqs_group_queue_name}", "arn:aws:sqs:*:*:${var.sqs_fifo_queue_name}.fifo"] : ["arn:aws:sqs:*:*:${var.sqs_queue_name}"]
condition {
test = "ArnEquals"
variable = "aws:SourceArn"
values = [var.sns_topic_arn]
}
}

}


data "aws_iam_policy_document" "this_dead_letter_queue_policy" {
statement {
sid = "DLQSendMessages"
Expand Down