Skip to content

Document all functions in the helpers directory#352

Merged
andrewtavis merged 1 commit into
scribe-org:mainfrom
Femimat:Issue-310
Apr 5, 2025
Merged

Document all functions in the helpers directory#352
andrewtavis merged 1 commit into
scribe-org:mainfrom
Femimat:Issue-310

Conversation

@Femimat
Copy link
Copy Markdown
Contributor

@Femimat Femimat commented Apr 4, 2025

Contributor checklist


Description

The PR adds doc comments to all the functions and classes in the helpers directory.

Related issue

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 4, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 4, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Copy Markdown
Member

Thanks for the PR @Femimat. We will get to review it soon :)

Copy link
Copy Markdown
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me @Femimat

@andrewtavis I think we could add doc strings rule for the files in detekt and ktlint and then create issues and further start enabling them for different files.

Copy link
Copy Markdown
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me as well, @Femimat! Thanks for all the hard work to get the application documented for the community! 😊

@andrewtavis
Copy link
Copy Markdown
Member

I'll make an issue for detekt and ktlint now :)

@andrewtavis andrewtavis merged commit d5bf161 into scribe-org:main Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants