Skip to content

Fix dangling top-level kdoc comments#390

Merged
andrewtavis merged 1 commit intoscribe-org:mainfrom
Femimat:Issue-364
Apr 24, 2025
Merged

Fix dangling top-level kdoc comments#390
andrewtavis merged 1 commit intoscribe-org:mainfrom
Femimat:Issue-364

Conversation

@Femimat
Copy link
Copy Markdown
Contributor

@Femimat Femimat commented Apr 22, 2025

Contributor checklist


Description

This pull request fixes dangling top-level KDoc comments.

Related issue

@github-actions
Copy link
Copy Markdown

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Copy Markdown
Member

@Femimat Could the conflicts be fixed ?

@Femimat
Copy link
Copy Markdown
Contributor Author

Femimat commented Apr 23, 2025

Okay @angrezichatterbox, I'll check it out.

@Femimat
Copy link
Copy Markdown
Contributor Author

Femimat commented Apr 23, 2025

Hi @angrezichatterbox, I’ve fixed the issue. You can review the PR now—thanks!

@angrezichatterbox
Copy link
Copy Markdown
Member

Hi @angrezichatterbox, I’ve fixed the issue. You can review the PR now—thanks!

I would look into it later today :)

Copy link
Copy Markdown
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me @Femimat. Its good for a merge :)

Copy link
Copy Markdown
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me as well, @Femimat :) Appreciate your continued work on these issues!

@andrewtavis andrewtavis merged commit c3847ac into scribe-org:main Apr 24, 2025
5 checks passed
majidhawa pushed a commit to majidhawa/Scribe-Android that referenced this pull request May 2, 2025
andrewtavis added a commit that referenced this pull request May 5, 2025
* fix: Fix dangling top-level kdoc comments (#390)

* Minor edits to docstrings and spacing

---------

Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants