Skip to content

feat/download data empty state button#599

Open
ashb155 wants to merge 3 commits intoscribe-org:mainfrom
ashb155:feat/download_screen_button
Open

feat/download data empty state button#599
ashb155 wants to merge 3 commits intoscribe-org:mainfrom
ashb155:feat/download_screen_button

Conversation

@ashb155
Copy link
Copy Markdown
Contributor

@ashb155 ashb155 commented Apr 9, 2026

Contributor checklist


Description

This PR adds an empty state banner to Scribe keyboards for when the keyboard has been installed but language data has not yet been downloaded.

Files changed:

  • input_method_view.xml — Added a Button with id empty_state_banner above the keyboard view
  • GeneralKeyboardIME.kt — Added logic in onStartInputView to check if the language database file exists, if not, the banner is shown and the command options bar is hidden. Tapping the banner opens Installation page where the user can download language data
  • The check uses getDatabasePath("${languageAlias}LanguageData.sqlite").exists() to reliably detect whether data has been downloaded.

Testing:
Tested on an emulator with no language data downloaded — the banner appears correctly above the keyboard. After downloading data, the banner is hidden and the normal command bar is shown.

Note: The banner text "Please download language data" is currently hardcoded in English.

Screenshots

image image

Related issue

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@ashb155 ashb155 changed the title Feat/download screen button feat/download data empty state button Apr 9, 2026
@andrewtavis
Copy link
Copy Markdown
Member

Thanks so much for the work here, @ashb155! Could we do a few more edits so that the UI matches the designs as detailed in this message here?

@ashb155
Copy link
Copy Markdown
Contributor Author

ashb155 commented Apr 11, 2026

will work on it @andrewtavis !

@ashb155
Copy link
Copy Markdown
Contributor Author

ashb155 commented Apr 12, 2026

Current designs @andrewtavis

Screenshot 2026-04-12 123805 Screenshot 2026-04-12 123823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add button to top of keyboard directing user to download screen when no data is downloaded

2 participants