Skip to content

allow multi-datatype-passes for convert_parser#635

Merged
andrewtavis merged 2 commits into
scribe-org:mainfrom
DeleMike:fix/convert-parser-to-allow-multi-datatype-passes
Aug 20, 2025
Merged

allow multi-datatype-passes for convert_parser#635
andrewtavis merged 2 commits into
scribe-org:mainfrom
DeleMike:fix/convert-parser-to-allow-multi-datatype-passes

Conversation

@DeleMike
Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

Related issue

@DeleMike DeleMike requested a review from andrewtavis August 20, 2025 13:00
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! ❤️

The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Data rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 20, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Copy Markdown
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fixes here, @DeleMike! Here's hoping that third time is the try to get all of this up and running. Really has been a marathon, and this has been really commendable work 👏😊

@andrewtavis andrewtavis merged commit 28d6764 into scribe-org:main Aug 20, 2025
6 checks passed
@DeleMike
Copy link
Copy Markdown
Collaborator Author

Thanks so much, @andrewtavis. I am hoping for that too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convert_parser not accepting multiple datatype passes

2 participants