feat: expand generated emoji keywords from 3 to 9#671
Conversation
Fixes scribe-org#670 Summary: Increase the maximum number of emoji suggestions per keyword from 3 to 9 to support the upcoming emoji autosuggest feature in Scribe client apps. Changes: - src/scribe_data/unicode/generate_emoji_keywords.py: Updated EMOJI_KEYWORDS_DICT constant from 3 to 9 - tests/unicode/test_generate_emoji_keywords.py: Updated test assertion to expect emojis_per_keyword=9 Impact: - Emoji keyword generation will now produce up to 9 emoji suggestions per word instead of 3 - Enables richer emoji suggestions via the : autosuggest functionality in Scribe client applications
Thank you for the pull request! 💙The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Data repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
note, @aicontentcreate2023-star: It looks like your email for GitHub isn't set up properly. See the message here for how to fix this for future commits :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Thanks for the great first commit, @aicontentcreate2023-star!
Fixes #670
Summary
Increase the maximum number of emoji suggestions per keyword from 3 to 9 to support the upcoming emoji autosuggest feature in Scribe client apps.
Changes
src/scribe_data/unicode/generate_emoji_keywords.py
EMOJI_KEYWORDS_DICTconstant from3to9emojis_per_keywordparameter passed togen_emoji_lexicon()tests/unicode/test_generate_emoji_keywords.py
emojis_per_keyword=9instead of3Impact
Testing
# Run the updated test pytest tests/unicode/test_generate_emoji_keywords.py -vThe change is minimal and low-risk — a single constant update with corresponding test coverage.