Not in Wikidata message isn't localized

[andrewtavis]

Terms

• I have searched all open bug reports
• I agree to follow Scribe-iOS' Code of Conduct

Behavior

The message that displays to the user when they click the "Not in Wikidata" information icon hasn't been changed to its localized form. We'd want this message to be in the keyboard's language so that the interface is as immersive as possible in the user's second language. The way we see this message is:

• Click the Scribe key
• Select a command like translate
• Translate some nonsense like gdfsajfdsjk
• See the "Not in Wikidata" message
• Click the information icon
• See that the text about Wikidata is in English instead of the keyboard language

Device type

iPhone and iPad

Versions

Current main branch

[Subham-KRLX]

Hi @andrewtavis 👋, I’d love to work on localizing the “Not in Wikidata” info message. I understand the string is currently hardcoded in English and we need to replace it with a NSLocalizedString(...) and add entries to each .strings file. Please let me know if there’s any preferred format or if anyone is already working on this—I’m happy to start submitting a PR!

[andrewtavis]

Hey @Subham-KRLX 👋 Would be great to have you work on this! Specifically there are three strings that explain Wikidata to the user, each of which are hard coded in English. We actually already have the localizations of these texts, they just haven't been applied :) They can be found in keyboard.not_in_wikidata.explanation_1, keyboard.not_in_wikidata.explanation_2 and keyboard.not_in_wikidata.explanation_3 as far as i18n keys are concerned :)

Assigning you now! Please let us know if there are any questions or ways that we can support!

[Subham-KRLX]

@andrewtavis This PR is ready for your review when you have time. Thanks!

[andrewtavis]

Thanks much, @Subham-KRLX! I'll take a look today or tomorrow hopefully :)