Added external link icon in "About" page (#393)

[Jag-Marcel]

• This pull request is on a separate branch and not the main branch

---

Description

This adds an icon to show that several buttons in the "About" page in the app link to external sites, mainly the ones outlined in the issue #393, with the exception of the "Share" button, which doesn't necessarily link to outside the app. I also thought that the "Share" icon was already universal enough for people to interpret what the button does at a glance.

I used the icon that was used as an example in the original issue, but it can be replaced by similar ones that might fit the style of the rest of icons better if there is a need.

I tested by using the Xcode iPhone 15 Pro, Pro Max and iPad Pro 11in simulators

Related issue

• Add external link icons to About menu options #393

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

Thanks for this, @Jag-Marcel! I'll get to this soon :)

[andrewtavis]

Generally everything's looking great here, @Jag-Marcel :) One thing to note is that the resolution of the icon isn't scaling particularly well. I guess I'd also prefer if the arrow was going right out at 45 degrees rather than say 55. Would something like this icon be possible. The other thought I'm having on this is also that the icon would ideally be grey like the chevrons that indicate navigating within the app.

Let me know if you'd like to work on the above two points! Thanks for the work till now 😊

[andrewtavis]

I realized that designs were missing for this, @Jag-Marcel :) I did some minor edits for it just now, which can be seen on Figma here: https://www.figma.com/file/c8945w2iyoPYVhsqW7vRn6/scribe_public_designs?type=design&node-id=513%3A2206&mode=design&t=ReaZQG3S33ML5O2k-1.

[Jag-Marcel]

Alright, I'll get to it. Should be a fairly simple change.

[andrewtavis]

Nice @Jag-Marcel, thanks for looking into this further 😊

[andrewtavis]

This is really great for the first contribution, @Jag-Marcel 😊 Appreciate the quick turn around in addressing the comments. Would be great to work with you on another issue!

Will bring this in and do some minor edits I'm seeing that are unrelated before closing the issue :)