Added an Api for Box.com #718
Merged
+122
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Forgot to run checkstyle. Need to fix some whitespace stuff. Will reopen in morning. |
Fixed whitespace errors, and added first draft of test. Will update test soon.
fixed some additional whitespace issues
fixed typo (string -> String)
Updated test. Should be working now
Made fixes to test
kullfar
approved these changes
Nov 8, 2016
| public final class Box20Example { | ||
|
|
||
| private static final String NETWORK_NAME = "Box"; | ||
| private static final String PROTECTED_RESOURCE_URL = "https://app.box.com/profile"; |
Member
There was a problem hiding this comment.
It's an almost super Pull Request, except for this URL ;-) it's not a protected API URL. It's usual html web page url.
There should be something like this
"https://api.box.com/2.0/users/me"
(or any other demonstrative url from here https://docs.box.com/reference)
It's the single minor problem here. I have fixed it while merging
Member
|
Good start, do not stop ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.