Skip to content

fs-adapter-store: barrel-export AdapterStoreBroadcast + bump 0.1.4#45

Merged
jasperboerhof merged 2 commits into
mainfrom
armory-adapter-store-broadcast-barrel
Apr 23, 2026
Merged

fs-adapter-store: barrel-export AdapterStoreBroadcast + bump 0.1.4#45
jasperboerhof merged 2 commits into
mainfrom
armory-adapter-store-broadcast-barrel

Conversation

@Goosterhof
Copy link
Copy Markdown
Contributor

Summary

  • Adds AdapterStoreBroadcast to packages/adapter-store/src/index.ts barrel alongside existing public type exports.
  • Bumps @script-development/fs-adapter-store 0.1.3 → 0.1.4.
  • Closes Scout M2 + Quartermaster M2 finding (Moderate API hygiene — type was introduced in 0.1.3 but never reached the barrel).

Context

AdapterStoreBroadcast<T> was defined and usable via deep import but absent from the package's canonical surface. Docs already document root-import (docs/packages/adapter-store.md:189) as the intended access path — the barrel omission was a promotion oversight at commit a3dfb12, not a deliberate API choice. This aligns implementation with the published contract.

Impact radius

Verified zero consumer breakage: kendo (^0.1.3) and BIO (^0.1.0) both carry the dep but do not currently import AdapterStoreBroadcast. Caret range will absorb 0.1.4 automatically on next install — no downstream action required.

Test plan

All 8 CI gates confirmed locally on branch:

  • `npm audit` — 0 vulnerabilities
  • `npm run format:check` (oxfmt) — 130 files, all correct
  • `npm run lint` (oxlint) — 0 warnings / 0 errors
  • `npm run -w @script-development/fs-adapter-store build` — dual ESM + CJS, AdapterStoreBroadcast re-exported in .d.mts + .d.cts, zero refs in emitted .mjs/.cjs (type-only)
  • `npm run -w @script-development/fs-adapter-store typecheck` — clean
  • `npm run -w @script-development/fs-adapter-store lint:pkg` — publint + attw (node10/node16 CJS+ESM/bundler) all green
  • `npm run -w @script-development/fs-adapter-store test:coverage` — 90/90 tests, 100% stmts/branches/funcs/lines
  • `npm run -w @script-development/fs-adapter-store test:mutation` — 100.00 score (92 killed, 0 survived; threshold 90%)

Publish

Tag/publish deferred until after merge — Commander-gated. Trusted Publishing (OIDC) triggers on tag push.

The AdapterStoreBroadcast<T> contract was introduced in commit a3dfb12
as part of the broadcast subscription redesign, but the barrel export
in src/index.ts was never updated to re-export it. The type is
documented in docs/packages/adapter-store.md as a canonical import
from the package root, surfaced through AdapterStoreConfig.broadcast,
and used by the package's own tests via the barrel — the omission
was a promotion oversight, not a deliberate API choice.

Adds AdapterStoreBroadcast to the existing export type { ... } block
and bumps the package version 0.1.3 → 0.1.4 for a patch release.
Type-only change; emitted .mjs/.cjs contain zero references. All 8
CI gates green locally (audit, format, lint, build, typecheck,
publint+attw, 100% coverage on 90 tests, 100% mutation / 92 killed).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 23, 2026

Deploying fs-packages with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d236f5
Status: ✅  Deploy successful!
Preview URL: https://b441839a.fs-packages.pages.dev
Branch Preview URL: https://armory-adapter-store-broadca.fs-packages.pages.dev

View logs

@jasperboerhof jasperboerhof merged commit 0a4526f into main Apr 23, 2026
2 checks passed
@jasperboerhof jasperboerhof deleted the armory-adapter-store-broadcast-barrel branch April 23, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants