Declare engines.node >=24.0.0 across root + 10 packages#47
Merged
jasperboerhof merged 3 commits intomainfrom Apr 23, 2026
Merged
Declare engines.node >=24.0.0 across root + 10 packages#47jasperboerhof merged 3 commits intomainfrom
jasperboerhof merged 3 commits intomainfrom
Conversation
Closes QM M2 F-6. CI pins Node 24 (actions/setup-node@v6, node-version: 24) but published manifests advertised no floor, leaving consumers to install on older Node without EBADENGINE warnings. Posture: strict >=24.0.0 matches CI. Source code uses zero Node APIs, so the declaration documents the tested surface, not a runtime requirement beyond what the toolchain already enforces (tsdown >=20.19.0, vitest 20/22/24, stryker >=20.0.0). oxfmt canonicalized engines to end-of-manifest on all 10 package files (I initially placed it after scripts; oxfmt moved it). Root already had it at the end — no move needed. Config-only correctness fix: no version bumps, no API change. Verification (8/8 gates green on this branch): - npm audit: 0 vulnerabilities - format:check: pass - lint: 0/0 (oxlint) - build: pass (tsdown now targets node24.0.0) - typecheck: pass - lint:pkg: 10/10 publint + attw pass (no engines warning) - test:coverage: 427/427 tests pass - test:mutation: 10/10 packages >=90% (range 91.20%-100%) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying fs-packages with
|
| Latest commit: |
97fe798
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://853a7c12.fs-packages.pages.dev |
| Branch Preview URL: | https://armory-node-engines-sweep.fs-packages.pages.dev |
jasperboerhof
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this number
Consumers on Node <24 will now get `EBADENGINE` warnings rather than silent runtime failures.
Nice side-effect
tsdown reads `engines.node` from the manifest and now builds with `target: node24.0.0`. Future library code using Node-24-native APIs will compile correctly without manual `target` config — not visible today (source uses zero Node APIs) but future-relevant.
oxfmt ordering note
oxfmt canonicalizes `engines` to end-of-manifest (after dependencies). One `npm run format` pass during this sweep moved it from after `scripts` to end-of-file; the committed state is the post-format one.
Test plan
All 8 CI gates confirmed locally: