ci: add PHP 8.5 to test matrix#6
Merged
Goosterhof merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
Adds 8.5 alongside 8.4 in both ci.yml and release.yml. The war-room dev environment already runs PHP 8.5.5 locally, so this lifts ad-hoc pre-push coverage into CI. Adding (not replacing) keeps the composer.json `^8.4` contractual minimum covered. Closes #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymland.github/workflows/release.ymlmatrices from['8.4']to['8.4', '8.5'].[Unreleased]inCHANGELOG.md.Why add (not replace)
PHP 8.5.0 was released 2025-11-20; the war-room dev environment already runs 8.5.5 locally, so PRs were getting ad-hoc 8.5 coverage during pre-push but no signal landed in CI. Per the issue's recommendation: adding (not replacing) keeps both ends of the supported range tested —
composer.jsonis^8.4, so dropping 8.4 from CI would silently weaken that contract. The CI cost is one extra leg per PR; the cost of a silent 8.5-only regression that breaks 8.4 consumers is a CHANGELOG line that shouldn't have been needed.shivammathur/setup-php@v2supports 8.5 since GA, and nothing in the codebase uses 8.5-only features today, so this is a low-risk add.Test plan
Closes #5
🤖 Generated with Claude Code