-
Notifications
You must be signed in to change notification settings - Fork 3
Canvas mode and UI fixes #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements full canvas mode functionality with enhanced window management and interactive table viewing features while also introducing a few technical improvements in search, rolling logic, and UI responsiveness.
- Key changes include: duplicate interface cleaning in shared types, updated search weight factors, and refactored components for better interaction and state management.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/shared/types.ts | Duplicate declaration of ForcedSelection interface that should be consolidated |
| src/renderer/hooks/useTableSearch.ts | Adjusted search weight configurations to better prioritize legacy and section names |
| src/renderer/components/TableWindow.tsx | Added and refined roll history, forced entry handling, and draggable window integration |
| src/renderer/components/TableList.tsx | Updated inline expansion logic from a single ID to a Set-based approach for multiple tables |
| Others | Various UI and utility improvements ensuring consistency and enhanced user experience |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Canvas Mode Implementation
Interactive Table Viewing
TableEntryViewercomponent for structured table entry displayDraggable Window System
DraggableWindowcomponent with resize and drag capabilitiesEnhanced Table Window Experience
TableWindowcomponent for interactive table results🔧 Technical Improvements
Search Enhancement
Roll Result Refactoring
InteractiveRollResultcomponent with hierarchical subroll structureData Structure Updates
ForcedSelectioninterface for targeted table rollingSubrollDatainterface with entry tracking and nested referencesrollOnTableWithForcedSelectionsfunctionality🎨 UI/UX Improvements
Styling Updates
Component Enhancements
TableListcomponent with view mode toggles📦 Version & Documentation
🔄 State Management