增强 chrome.tabs.create 兼容性#639
Merged
CodFrm merged 3 commits intoscriptscat:mainfrom Aug 20, 2025
Merged
Conversation
CodFrm
reviewed
Aug 20, 2025
| // 失敗的話,刪去 openerTabId 和 windowId ,再次嘗試打開 | ||
| delete createProperties.openerTabId; | ||
| delete createProperties.windowId; | ||
| await chrome.tabs.create(createProperties); |
Member
There was a problem hiding this comment.
可以直接return chrome.tabs.create(createProperties);
Collaborator
Author
There was a problem hiding this comment.
也可以。只是看你的设计没这个需要,所以只回传了 void
CodFrm
added a commit
that referenced
this pull request
Aug 25, 2025
* 增强 chrome.tabs.create 兼容性 * 优化一些窗口的打开 * 第二次不用 try catch. 还是无法打开的话就报错,否则难以调试及用户回馈 --------- Co-authored-by: 王一之 <yz@ggnb.top>
CodFrm
pushed a commit
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
部份瀏覽器不支持 openerTabId ,windowId 等options