getCombinedMeta(metaBase: SCMetadata, metaCustom: SCMetadata)#690
Merged
CodFrm merged 1 commit intoscriptscat:mainfrom Aug 29, 2025
Merged
getCombinedMeta(metaBase: SCMetadata, metaCustom: SCMetadata)#690CodFrm merged 1 commit intoscriptscat:mainfrom
CodFrm merged 1 commit intoscriptscat:mainfrom
Conversation
Member
|
?: 的话，就不用判断 selfMetadata 是不是 undefined了 |
Member
|
如果beta分支要改的话，应该是从beta分支上去修改，然后再合并到main |
Collaborator
Author
代码是可以这样。TypeScript是不会报错。但逻辑上有错 以前你讲过类似不要为了单元测试而改动本来的代码之类 （当时我打算搞一个为了单元测试而做的函数) 这个 getCombinedMeta 是要两个 meta 合在一起 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beta 分支的單元測試也要同樣更新