Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

Conversation

@randomairborne
Copy link
Member

This PR improves the failure message for the ping command

Copy link
Member

@tazz4843 tazz4843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way too prone to other languages breaking (don't be Anglocentric). Use entirely new strings if you need to in the translation files.

@randomairborne
Copy link
Member Author

randomairborne commented Nov 18, 2022 via email

@tazz4843
Copy link
Member

Can't merge this then, screws with other languages too much.

@tazz4843 tazz4843 closed this Nov 18, 2022
@randomairborne
Copy link
Member Author

What other options do you propose? The way it's done now is very messy.

@randomairborne
Copy link
Member Author

This decision also makes it pretty impossible to ever change formatting on a message, as you need all of the translators to update along in the same PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants