feat(recursion-v2): add leaf verifier prover wiring#1367
Merged
Conversation
- Add rebuild_circuit_index() to ZKVMVerifyingKey for post-deserialization reconstruction of the serde-skipped circuit_index_to_name field. - Use --pcs=basefold in run_e2e_test.sh to match the test's expected PCS type. - Uncomment PvsAirConsistencyBus add_key_with_lookups in VerifierPvsAir to fix LogUp bus imbalance with UnsetPvsAir's lookup_key calls. - Add dump_fixture_public_values diagnostic test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add AggProver<LEAF_FANIN, INTERNAL_FANIN> that orchestrates the full recursion pipeline: leaf → internal → root. Leaf and internal layers have independent fanin constants and system params via AggregationOptions. Rewrite e2e tests to use AggProver instead of InnerCpuProver directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1365. Stacked on #1363.
Summary
AggProver<LEAF_FANIN, INTERNAL_FANIN>orchestrating the leaf → internal → root recursion pipeline with configurable fanin and system params per layerrebuild_circuit_index()onZKVMVerifyingKeyfor post-deserialization reconstruction of the serde-skipped index mapPvsAirConsistencyBusLogUp imbalance (uncommentadd_key_with_lookupsin VerifierPvsAir)--pcs=basefoldin fixture generation to match the test's expected PCS typeAggProverAPITest plan
bash ceno_recursion_v2/scripts/run_e2e_test.sh(generates fixtures + runs all prover_integration tests)