[precompile] aggregate lookup expression within keccak precompile #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
force-pushed
the
feat/lookup_aggregate_in_keccak
branch
from
1876357 to
6e53d94
Compare
spherel
reviewed
Jun 30, 2025
| let mut evaluations = evaluations; // Change evaluations' lifetime. | ||
| evaluations.resize_with(circuit.n_evaluations, || &field_type_default); | ||
| challenges.resize_with(circuit.n_challenges, || E::random(&mut rng)); | ||
| challenges.resize_with(2 + circuit.n_challenges, || E::random(&mut rng)); |
Collaborator
Author
There was a problem hiding this comment.
index 0, 1 is for alpha, beta global challenge. Here circuit.n_challenges only counting local challenges, which is 0.
we can make this converation open without Resolve 👍 , so it can be refer from future task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
to support e2e integration, build on top of #971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aggregate lookup expression in keccak precompile instead of pass flatten out_evals of raw lookup value.
This make later gkr-iop flow integration easier when integrate into ceno main proving flow
benchmark
with command on
researchbench serverThere shows prover performance keccak precompile regressed which is expected. Because the cost to aggregate them always there, just we do it within chip or outside chip.