Skip to content

Conversation

@yqrashawn
Copy link
Contributor

@yqrashawn yqrashawn commented Oct 24, 2024


PR Summary

resolve GEN-1305
read user's default language preference from window.navigator


Checklist

  • There are breaking changes
  • I've added/changed/removed ENV variable(s)
  • I checked whether I should update the docs and did so by updating /docs

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
frontends ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 0:41am

@netlify
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for scroll-io ready!

Name Link
🔨 Latest commit 614beaf
🔍 Latest deploy log https://app.netlify.com/sites/scroll-io/deploys/671ae91e79350b0008908988
😎 Deploy Preview https://deploy-preview-1339.env.scroll.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yqrashawn yqrashawn requested a review from Holybasil October 24, 2024 12:04
@Holybasil
Copy link
Member

maybe we should upgrade the version number to clear the locally stored blogLanguage for users, so it defaults to reading the browser settings? @yqrashawn

Signed-off-by: yqrashawn <namy.19@gmail.com>
@yqrashawn yqrashawn force-pushed the blog-user-default-lang branch from 467d489 to 614beaf Compare October 25, 2024 00:41
@yqrashawn yqrashawn merged commit d424519 into sepolia Oct 26, 2024
11 checks passed
@yqrashawn yqrashawn deleted the blog-user-default-lang branch October 26, 2024 08:11
Holybasil added a commit that referenced this pull request Oct 26, 2024
feat: read user default language from browser (#1339)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants