Skip to content

Conversation

@Thegaram
Copy link

@Thegaram Thegaram commented Nov 6, 2025

1. Purpose or design rationale of this PR

Add missing precompile activation.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for Galileo network upgrade with dynamic precompile contract selection based on network rules. System intelligently maps to appropriate contract implementations while maintaining backward compatibility with previous network versions.
  • Chores

    • Patch version updated from 8 to 9

@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Walkthrough

This PR introduces Galileo fork support to the EVM's precompile selection logic by adding a conditional check for evm.chainRules.IsGalileo in the precompile(addr) method, and bumps the patch version from 8 to 9.

Changes

Cohort / File(s) Change Summary
Galileo Fork Support
core/vm/evm.go
Adds conditional branch to select PrecompiledContractsGalileo when Galileo fork is active; preserves existing precompile mappings for all prior forks.
Version Bump
params/version.go
Updates VersionPatch constant from 8 to 9, propagating to computed version outputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Straightforward conditional logic addition following established fork pattern
  • Minor version constant update with no semantic impact
  • Changes are localized and introduce no new control flow complexities

Possibly related PRs

Suggested reviewers

  • roynalnaruto
  • georgehao
  • mmjahanara

Poem

🐰 A Galileo bloom, so bright and new,
Precompiles aligned, fork-rules ring true,
Version nine dances, from eight we flew,
Stars align in contracts—what magic we brew! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and concisely summarizes the main change: adding the missing Galileo precompile activation, which aligns with the core modification in evm.go.
Description check ✅ Passed The pull request description covers all required template sections: purpose, PR title type (fix), deployment versioning (Yes with version.go update), and breaking change confirmation (No).
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-galileo-precompile-activation

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53408ef and 2ed0d00.

📒 Files selected for processing (2)
  • core/vm/evm.go (1 hunks)
  • params/version.go (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
core/vm/evm.go (1)
core/vm/contracts.go (1)
  • PrecompiledContractsGalileo (164-175)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
params/version.go (1)

27-27: LGTM! Version bump is appropriate.

The patch version increment from 8 to 9 correctly reflects this fix and follows standard versioning practices.

core/vm/evm.go (1)

50-51: LGTM! Galileo precompile activation is complete and correct.

Verification confirms the Galileo fork is consistently activated across all critical locations: precompile selection, instruction set assignment, active precompile list, and fee calculations. The placement at the top of switch statements correctly prioritizes the newest fork.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Thegaram Thegaram merged commit 9cfdf86 into develop Nov 6, 2025
14 checks passed
@Thegaram Thegaram deleted the fix-galileo-precompile-activation branch November 6, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants