Native Sumcheck Layer Evaluation #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunxian-xia
reviewed
Nov 17, 2025
kunxian-xia
reviewed
Nov 17, 2025
kunxian-xia
reviewed
Nov 17, 2025
kunxian-xia
reviewed
Nov 17, 2025
kunxian-xia
reviewed
Nov 17, 2025
|
|
||
| self.memory_bridge | ||
| .read( | ||
| MemoryAddress::new(self.address_space, register_ptrs[0] + AB::F::from_canonical_usize(EXT_DEG * 2 - 1) + curr_prod_n), |
There was a problem hiding this comment.
I see, since curr_prod_n starts from 1.
Author
There was a problem hiding this comment.
The formula is rewritten to make sure it's clear the -1 is grouped with curr_prod_n. Comment added.
|
|
||
| self.memory_bridge | ||
| .read( | ||
| MemoryAddress::new(self.address_space, register_ptrs[0] + AB::F::from_canonical_usize(EXT_DEG * 2 - 1) + ctx[1] + curr_logup_n), |
Author
There was a problem hiding this comment.
The formula is rewritten to make sure it's clear the -1 is grouped with curr_logup_n. Comment added.
8 tasks
Merged
kunxian-xia
added a commit
that referenced
this pull request
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a custom opcode
SUMCHECK_LAYER_EVALfor calculating layer evaluation.v'[b] = v[b,0] * v[b,1];p'[b] = p[b,0]*q[b,1] + p[b,1]*q[b,0], q'[b] = q[b,0]*q[b,1]The new added opcode supports two modes:
p[r] = eq(0,r)*p[0] + eq(1,r)*p[1].Layout
Each row is able to process 1 product sumcheck or 1 logup sumcheck.
Performance
layout for new chip
NativeSumcheck