feat(eth-wire): announce block to all neighbors #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #336 will not alter performanceComparing Summary
|
greged93
previously approved these changes
Sep 15, 2025
greged93
left a comment
greged93
left a comment
There was a problem hiding this comment.
lgtm! Just need to fix the lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables broadcast to all on reth. Specifically, it changes the
eth-wireannounce new blockto send a new block to all neighbors instead of the sqrt. This is necessary in the interim until l2geth gets deprecated as we only announce new blocks and not new block hashes from RN. Once we deprecate l2geth this functionality is not used anymore as then blocks are propagated viascroll-wireprotocol.