Skip to content

feat: explicitly set the chain id to None #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

feat: explicitly set the chain id to None #351

merged 2 commits into from
Oct 22, 2025

Conversation

@greged93
Copy link
Collaborator

No description provided.

@greged93
feat: explicitly set the chain id to None
1c7b5e3 
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
@greged93 greged93 requested a review from frisitano October 22, 2025 11:31
frisitano
frisitano approved these changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #351 will not alter performance

Comparing fix/tx-env-chain-id (9d13791) with scroll (32019bc)1

Summary

✅ 77 untouched

Footnotes

  1. No successful run was found on scroll (f3338ab) during the generation of this report, so 32019bc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@greged93 greged93 merged commit 5edac54 into scroll Oct 22, 2025
44 of 45 checks passed
@greged93 greged93 deleted the fix/tx-env-chain-id branch October 22, 2025 13:02
@lightsing lightsing mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frisitano frisitano frisitano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greged93 @frisitano