-
Notifications
You must be signed in to change notification settings - Fork 5
feat: gracefully handle commit/finalize genesis batch event #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gracefully handle commit/finalize genesis batch event #383
Conversation
CodSpeed Performance ReportMerging #383 will not alter performanceComparing Summary
|
|
just a note here: the genesis batch isn't persisted to DB, we persist a default empty batch. However, the genesis batch commits to the genesis of the chain, which we already have in the EN. |
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned that we are adding additional computational overhead in the statement for no functional difference in processing:
.filter(|decoded| !decoded.data.batch_index.is_zero())
Claude says the computational overhead is minimal, shouldn't bring performance issue for L1 watcher at all. And we kinda need this filter to skip genesis batch commit event. I can move the filter logic above |
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR add feature to gracefully handle commit/finalize genesis batch event.
corresponding issue: #369