Skip to content

Conversation

@colinlyguo
Copy link
Contributor

@colinlyguo colinlyguo commented Feb 18, 2024

Purpose or design rationale of this PR

Fix a bug that would cause panic.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo added bug Something isn't working bump-version Bump the version tag for deployment labels Feb 18, 2024
@codecov
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6030927) 57.07% compared to head (d4cc0ea) 57.07%.

Files Patch % Lines
rollup/internal/controller/sender/sender.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1133   +/-   ##
========================================
  Coverage    57.07%   57.07%           
========================================
  Files          150      150           
  Lines        11203    11203           
========================================
  Hits          6394     6394           
  Misses        4364     4364           
  Partials       445      445           
Flag Coverage Δ
rollup 65.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xmountaintop 0xmountaintop merged commit e5e5caf into develop Feb 19, 2024
@0xmountaintop 0xmountaintop deleted the fix-sender-panic-when-resubmitting-failed branch February 19, 2024 01:45
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
13 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working bump-version Bump the version tag for deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants