Skip to content

Conversation

@reuvenpo
Copy link
Contributor

@reuvenpo reuvenpo commented May 22, 2021

This PR implements the TransactionHistory query and Private Memo features of SNIP-21

This PR also adds a check in Deposit that the tokens being deposited are of the expected kind (sSCRT). If another token is deposited, then the deposit fails. This is applicable for IBC.

@reuvenpo reuvenpo changed the title Transaction history + Private memo Transaction History + Private memo May 22, 2021
@reuvenpo reuvenpo changed the title Transaction History + Private memo SNIP21 - Transaction History + Private memo May 23, 2021
@reuvenpo reuvenpo changed the title SNIP21 - Transaction History + Private memo SNIP-21 - Transaction History + Private memo May 23, 2021
Copy link
Member

@toml01 toml01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌🏼

@reuvenpo reuvenpo merged commit 6b7e750 into master May 25, 2021
@reuvenpo reuvenpo deleted the transaction-history branch May 25, 2021 15:18
cboh4 pushed a commit that referenced this pull request Jun 23, 2025
remove prng store, update create viewing key to make entropy optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants