Avoid changing the mbstring encoding when useless in the Parser#321
Merged
stof merged 1 commit intoscssphp:masterfrom Mar 13, 2021
Merged
Avoid changing the mbstring encoding when useless in the Parser#321stof merged 1 commit intoscssphp:masterfrom
stof merged 1 commit intoscssphp:masterfrom
Conversation
The Parser does not use mbstring itself. The only reason to change the encoding is to ensure compatibility with the mbstring.func_overload feature of PHP, as we rely on the fact that standard PHP functions are dealing with bytes, not with multibyte chars (which would not be compatible with preg_match offsets which are not overloaded). There is no need to change that global state if that obsolete PHP feature is not enabled.
stof
commented
Mar 12, 2021
| private function saveEncoding() | ||
| { | ||
| if (\extension_loaded('mbstring')) { | ||
| if (\PHP_VERSION_ID < 80000 && \extension_loaded('mbstring') && (2 & (int) ini_get('mbstring.func_overload')) > 0) { |
Member
Author
There was a problem hiding this comment.
the PHP version check is because the feature is gone entirely in PHP 8.0 (it is deprecated since PHP 7.2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Parser does not use mbstring itself. The only reason to change the encoding is to ensure compatibility with the mbstring.func_overload feature of PHP, as we rely on the fact that standard PHP functions are dealing with bytes, not with multibyte chars (which would not be compatible with preg_match offsets which are not overloaded).
There is no need to change that global state if that obsolete PHP feature is not enabled.