Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISTS: Initial Emscripten Demo / Proof of Concept #3046

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

@chkuendig
Copy link

@chkuendig chkuendig commented Jun 4, 2021

This is an initial version of my Emscripten/Webassembly target as mentioned on Discord a few days ago (see video https://discord.com/channels/581224060529148060/581224061091446795/849353211877523536)

There's still a lot to do depending on how such a build would be deployed. I summarized quick build instructions and a summary of what's done and what's still missing at ./dists/emscripten/README.md.

I built a demo based on this (running ./dists/emscripten/build.sh all) and uploaded it to http://scummvm.kuendig.io/scummvm.html. This includes some freeware games, some demos and the ScummVM testbed.

I only tested this on macOS, but at least in theory this should also build on Linux and WSL (or anything else that can run shell scripts and is supported by emsdk).

Update 7th June: I fixed a few more minor issues and updated the demo at http://scummvm.kuendig.io/scummvm.html - feel free to retest. Let me know what you think. I'll keep improving this in the coming days and address any further review comments.

engines/grim/grim.cpp Outdated Show resolved Hide resolved
graphics/opengl/framebuffer.cpp Outdated Show resolved Hide resolved
graphics/opengl/shader.cpp Outdated Show resolved Hide resolved
@chkuendig chkuendig force-pushed the chkuendig:emscripten branch 4 times, most recently from 8d3300d to 40ef4a2 Jun 4, 2021
@chkuendig
Copy link
Author

@chkuendig chkuendig commented Jun 4, 2021

I tried to fix most codacy errors. I'm not sure if the remaining once have any relevance.

Update 6/6: I fixed them all 🙂

@chkuendig chkuendig force-pushed the chkuendig:emscripten branch from eb5544c to 1081315 Jun 7, 2021
@chkuendig chkuendig force-pushed the chkuendig:emscripten branch from 1081315 to 8136e1c Jun 7, 2021
configure Show resolved Hide resolved
chkuendig added 3 commits Jun 8, 2021
- too verbose logging slows down everything
- datadir / causes the whole FS to be scanned at launch, including files which are loaded lazily via XHR
- corrupt default data in local storage
- double-slash in path of VORBIS_LIBS
@chkuendig chkuendig force-pushed the chkuendig:emscripten branch from d2ca437 to bbb272a Jun 8, 2021
@chkuendig
Copy link
Author

@chkuendig chkuendig commented Jun 8, 2021

I pushed a few more minor improvements and bug fixes today. There's still a few minor bugs and quite a lot potential improvements and I could probably work on this branch for the foreseeable future (and mark this PR as a draft).

OTOH I was wondering what would be a good point to get this initial state merged from the projects perspective? I could then focus on this and postpone a few of the less important improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants