DISTS: Initial Emscripten Demo / Proof of Concept #3046
Conversation
chkuendig
force-pushed
the
emscripten
branch
4 times, most recently
from
8d3300d
to
40ef4a2
Compare
|
I tried to fix most codacy errors. I'm not sure if the remaining once have any relevance. Update 6/6: I fixed them all 🙂 |
This is an initial version of the emscripten build/dist target. Many things are still missing, see dists/emscripten/README.md for a detailed summary of what this provides and still misses
…0ms delay in GRIM main loop
- too verbose logging slows down everything - datadir / causes the whole FS to be scanned at launch, including files which are loaded lazily via XHR - corrupt default data in local storage - double-slash in path of VORBIS_LIBS
|
I pushed a few more minor improvements and bug fixes today. There's still a few minor bugs and quite a lot potential improvements and I could probably work on this branch for the foreseeable future (and mark this PR as a draft). OTOH I was wondering what would be a good point to get this initial state merged from the projects perspective? I could then focus on this and postpone a few of the less important improvements. |
There was a problem hiding this comment.
I made a couple more minor comments.
I think we may merge it as soon as those are addressed. Would you like to join the team as an official porter?
A question, is it possible to somehow create a standalone version from it? E.g. basically a release build?
I love this port, and while of course, it is a resource hog, I was able to just open it and play on my non-jailbroken iPad. Yay!
I'll address these as soon as possible. Would love to join. Does this involve anything I should know about that?
Yes, my idea was to get this to build some type of bare bone minimal release. I'll see that I'll add this. At the moment this is a bit hobbled together with the bundling of the demos. |
|
I tested the live demo from http://scummvm.kuendig.io/scummvm.html in the Switch browser and it doesn't work. Nintendo probably disabled some HTML5 APIs to avoid people playing games there 😞 |
|
Not much is involved in being a porter except continue to show love for your port, address blocker issues (if any) and be around the release time which is coordinated via scummvm-devel mailing list. Looking forward to the review issues addressed and the port merged. |
|
@chkuendig any update? |
|
Sorry, I didn't have much free time in the last few weeks to work on this. I still plan though to get this merged asap. But it might take a few more weeks until I'll be able to address everything. |
chkuendig
force-pushed
the
emscripten
branch
2 times, most recently
from
9aa4768
to
f3c2018
Compare
|
Fixed the last minor issues. There's three larger topics I plan to tackle later:
Happy to join the team as a porter. |
| @@ -1117,6 +1117,13 @@ void GrimEngine::mainLoop() { | |||
| g_imuseState = -1; | |||
| } | |||
|
|
|||
| #if defined(__EMSCRIPTEN__) | |||
There was a problem hiding this comment.
The preprocessor directives must have zero indentation, e.g. start from the column 1 per our code formatting giudelines.
| glRenderbufferStorage(GL_RENDERBUFFER, GL_STENCIL_INDEX8, _texWidth, _texHeight); | ||
| glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_STENCIL_ATTACHMENT, GL_RENDERBUFFER, _renderBuffers[1]); | ||
| const char *glVersion = (const char *)glGetString(GL_VERSION); | ||
| if (strstr(glVersion,"WebGL 1.0") != NULL) { |
| if (strstr(glVersion,"WebGL 1.0") != NULL) { | ||
| // See https://www.khronos.org/registry/webgl/specs/latest/1.0/#FBO_ATTACHMENTS | ||
| // and https://github.com/emscripten-core/emscripten/issues/4832 | ||
| #ifndef GL_DEPTH_STENCIL |
There was a problem hiding this comment.
Same thing regarding the preprocessor directives
|
Just minor formatting issues and we're fine to merge. |
|
Actually, let me merge it and then fix after by myself. |
This is an initial version of my Emscripten/Webassembly target as mentioned on Discord a few days ago (see video https://discord.com/channels/581224060529148060/581224061091446795/849353211877523536)
There's still a lot to do depending on how such a build would be deployed. I summarized quick build instructions and a summary of what's done and what's still missing at ./dists/emscripten/README.md.
I built a demo based on this (running
./dists/emscripten/build.sh all) and uploaded it to http://scummvm.kuendig.io/scummvm.html. This includes some freeware games, some demos and the ScummVM testbed.I only tested this on macOS, but at least in theory this should also build on Linux and WSL (or anything else that can run shell scripts and is supported by emsdk).
Update 7th June: I fixed a few more minor issues and updated the demo at http://scummvm.kuendig.io/scummvm.html - feel free to retest. Let me know what you think. I'll keep improving this in the coming days and address any further review comments.
Update 21st July: I didn't have much time in the last few weeks to work on this. I still plan though to get this merged this summer/asap. But it might take a few more weeks until I'll be able to address the remaining reviews.