VIDEO: Fix seeking to a keyframe in BINK videos#7180
Merged
lephilousophe merged 1 commit intoscummvm:masterfrom Feb 1, 2026
Merged
VIDEO: Fix seeking to a keyframe in BINK videos#7180lephilousophe merged 1 commit intoscummvm:masterfrom
lephilousophe merged 1 commit intoscummvm:masterfrom
Conversation
When seeking to a keyframe, that is not the first frame of the video, audio should not break or desync The special code in BinkDecoder::BinkAudioTrack::seek() for fixing audio underrun should apply in the case of key frames as well A test case for this issue can be constructed in MYST3, if the video at the start (10002), when Catherine is sitting on the bench with the baby and talks to the stranger, is set to start at frame 1 instead of 2.
Member
|
Without knowing anything about the codec, this seems completely sensible. |
Member
unfortunately I can't add anything more, but also sensible for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When seeking to a keyframe, that is not the first frame of the video, audio should not break or desync
The special code in BinkDecoder::BinkAudioTrack::seek() for fixing audio underrun should apply in the case of key frames as well
A test case for this issue can be constructed in MYST3, if the video at the start (10002), when Catherine is sitting on the bench with the baby and talks to the stranger, is set to start at frame 1 instead of 2.
If the fix is correct, it allows for some (future) fixes in the video playing code for Myst 3, that are currently breaking due to this audio issue.