Skip to content

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Oct 13, 2025

Fixes #124

discovered by @quentinblampey in #116 (comment)

super strange: why is the cs{rc}_{matrix_array} result different than when using numpy?

@flying-sheep flying-sheep changed the title fix: fix sum precision fix: sum precision Oct 13, 2025
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.32%. Comparing base (49bdfac) to head (7b08275).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   98.32%   98.32%   -0.01%     
==========================================
  Files          17       17              
  Lines         419      418       -1     
==========================================
- Hits          412      411       -1     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flying-sheep flying-sheep marked this pull request as draft October 13, 2025 10:07
Copy link

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #125 will not alter performance

Comparing pa/fix-precision (7b08275) with main (49bdfac)

Summary

✅ 160 untouched

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want me to review this @flying-sheep ? The tests seem quite broken?

@flying-sheep
Copy link
Member Author

flying-sheep commented Oct 13, 2025

We talked about how to handle it already, so I think we’re good for now!

scipy/scipy#23768

@flying-sheep flying-sheep marked this pull request as ready for review October 14, 2025 08:00
@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Oct 14, 2025
@flying-sheep flying-sheep changed the title fix: sum precision fix: Have sum operate on the passed dtype. Oct 14, 2025
@github-actions github-actions bot removed the run-gpu-ci Apply this label to run GPU CI once label Oct 14, 2025
@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Oct 14, 2025
@github-actions github-actions bot removed the run-gpu-ci Apply this label to run GPU CI once label Oct 14, 2025
@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Oct 14, 2025
@github-actions github-actions bot removed the run-gpu-ci Apply this label to run GPU CI once label Oct 14, 2025
@flying-sheep
Copy link
Member Author

now it’s ready!

@flying-sheep flying-sheep merged commit 9df6b5a into main Oct 15, 2025
19 of 21 checks passed
@flying-sheep flying-sheep deleted the pa/fix-precision branch October 15, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sum behaves differently from numpy when passed fractions

2 participants