-
Notifications
You must be signed in to change notification settings - Fork 1
fix: Have sum
operate on the passed dtype.
#125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 98.32% 98.32% -0.01%
==========================================
Files 17 17
Lines 419 418 -1
==========================================
- Hits 412 411 -1
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #125 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really want me to review this @flying-sheep ? The tests seem quite broken?
We talked about how to handle it already, so I think we’re good for now! |
sum
precisionsum
operate on the passed dtype.
now it’s ready! |
Fixes #124
discovered by @quentinblampey in #116 (comment)
super strange: why is the
cs{rc}_{matrix_array}
result different than when using numpy?