- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
          Support Dask in min/max
          #135
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Codecov Report❌ Patch coverage is  
 
 Additional details and impacted files@@             Coverage Diff             @@
##             main     #135       +/-   ##
===========================================
- Coverage   99.13%   47.13%   -52.00%     
===========================================
  Files          19       15        -4     
  Lines         464      367       -97     
===========================================
- Hits          460      173      -287     
- Misses          4      194      +190     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| CodSpeed Performance ReportMerging #135 will degrade performances by 22.41%Comparing  Summary
 
 Benchmarks breakdown
 | 
mean_var and support Dask in min/maxmin/max
      | OK, looks like there are more issues with min/max, I’m sorry that I didn’t catch that before making the release. | 
| 
 Yes, it seems so... | 

Closes #134
I updated the dtype behavior for dask to fix #134.
I also added support for DiskArray in mean_var - I think we just needed to always
np.powerinstead of the**notation. Except if you had a specific reason to use**@flying-sheep?I think it's very inefficient though, since it will move the result of the power operation directly in memory (at least, this is what I understand, but it may be wrong). We would like to have it in memory only after the mean reduction, but maybe there is no other way to do that - I'm not familiar enough with
h5.Datasets.I wanted to add some tests but I don't understand all the details of the tests, is there any instructions or CONTRIBUTING.md file I could use to run and update the tests?