test rapids build backend#639
Conversation
for more information, see https://pre-commit.ci
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request migrates the build backend from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
dependencies.yaml (1)
16-31: Optional: consider upper bounds on the publishedrapidsextra.The development pins in
hatch.tomluse<26.8forcudf/cuml/cugraph/cuvs, but the user-facing extra generated from this file uses only>=25.10with no upper bound, andcupy-cuda{12,13}xis fully unpinned. If RAPIDS 26.x introduces breaking API changes tocudf/cuml/cugraph/cuvs(or cupy ships a new major),pip install rapids-singlecell[rapids] --extra-index-url …could resolve to versions that haven't been validated against this release.Mirroring the hatch upper bound (or at least bounding the next major) would keep the published extra aligned with what's actually being tested.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@dependencies.yaml` around lines 16 - 31, The published extra currently uses open-ended pins for cupy-cuda12x/cupy-cuda13x and uses lower bounds only for cudf-cu12/cudf-cu13, cuml-cu12/cuml-cu13, cugraph-cu12/cugraph-cu13, cuvs-cu12/cuvs-cu13; update the matrix package entries to include an upper bound that mirrors the hatch dev pin (e.g. <26.8 or at least <27.0) for cudf/cuml/cugraph/cuvs and add a bounded pin or major-only upper bound for cupy-cuda12x/cupy-cuda13x so the rapids extra resolves to tested major versions (refer to the package names in the matrix blocks: cupy-cuda12x, cupy-cuda13x, cudf-cu12, cuml-cu12, cugraph-cu12, cuvs-cu12 and their -cu13 variants).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@dependencies.yaml`:
- Around line 16-31: The published extra currently uses open-ended pins for
cupy-cuda12x/cupy-cuda13x and uses lower bounds only for cudf-cu12/cudf-cu13,
cuml-cu12/cuml-cu13, cugraph-cu12/cugraph-cu13, cuvs-cu12/cuvs-cu13; update the
matrix package entries to include an upper bound that mirrors the hatch dev pin
(e.g. <26.8 or at least <27.0) for cudf/cuml/cugraph/cuvs and add a bounded pin
or major-only upper bound for cupy-cuda12x/cupy-cuda13x so the rapids extra
resolves to tested major versions (refer to the package names in the matrix
blocks: cupy-cuda12x, cupy-cuda13x, cudf-cu12, cuml-cu12, cugraph-cu12,
cuvs-cu12 and their -cu13 variants).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bec9e135-bf96-42e5-b1f4-bc01bc384e37
📒 Files selected for processing (12)
.github/workflows/publish.ymlci/environment.ymlci/environment_alpha.ymlconda/rsc_rapids_26.04_cuda12.ymlconda/rsc_rapids_26.04_cuda13.ymldependencies.yamldocs/contributing.mddocs/installation.mddocs/release-notes/0.15.0rc6.mddocs/release-notes/index.mdhatch.tomlpyproject.toml
No description provided.