fix: dotplot scaling with swapped axes #3851
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Despite the title of the corresponding issue, I took
to mean that scaling was not the problem.
But it turns that that is indeed broken and actually both scaling methods were broken with swapped axes for a very explainable reason - the scaling operation was happening on the wrong axis when the axis was swapped because it was fixed. Group scaling always happened on axis 0, for example, even though the group could be on axis 1 when the axes are swapped.
If you run the test suite on main without the changes, there should be errors for only the two swapped axes tests. Arguably the tests should be pared down, but parametrizing is free and easy. Happy to remove the extra ones.