Skip to content

Conversation

@flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Nov 14, 2025

looks like all the hairy manual padding stuff would not play well with actually supporting it, so away it goes.

@flying-sheep flying-sheep added this to the 1.12.0 milestone Nov 14, 2025
@flying-sheep flying-sheep enabled auto-merge (squash) November 14, 2025 12:50
@flying-sheep flying-sheep changed the title Support colorbar_loc in sc.pl.scatter fix: support colorbar_loc in sc.pl.scatter Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.82%. Comparing base (10fe134) to head (1b1d614).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3894   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files         116      116           
  Lines       12398    12398           
=======================================
  Hits         9525     9525           
  Misses       2873     2873           
Flag Coverage Δ
hatch-test.pre 76.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/plotting/_anndata.py 85.58% <100.00%> (ø)
src/scanpy/plotting/_docs.py 100.00% <ø> (ø)
src/scanpy/plotting/_tools/scatterplots.py 83.13% <ø> (ø)
src/scanpy/plotting/_utils.py 77.57% <ø> (ø)

@flying-sheep flying-sheep changed the title fix: support colorbar_loc in sc.pl.scatter docs: remove falsely advertised parameters from sc.pl.scatter Nov 14, 2025
@flying-sheep flying-sheep merged commit 508f857 into main Nov 14, 2025
18 checks passed
@flying-sheep flying-sheep deleted the pa/fix-scatter-params branch November 14, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: scatter() got an unexpected keyword argument 'colorbar_loc'

2 participants