Skip to content

Conversation

@PierreBoyeau
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PierreBoyeau PierreBoyeau requested a review from adamgayoso May 12, 2023 22:38
@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:42Z
----------------------------------------------------------------

"Differential expression on C. elegans data"


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:42Z
----------------------------------------------------------------

edit the first sentence to be more accurate


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:43Z
----------------------------------------------------------------

remove the comment


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:44Z
----------------------------------------------------------------

remove, colab has plotnine.

Let's not use opentsne, we can just use scanpy


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:45Z
----------------------------------------------------------------

use the backup url option of sc.read() and merge with the cell below


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:46Z
----------------------------------------------------------------

we need to say something about why you need to do gene selection and why this method is or isn't appropriate. You can use a "Note" admonition (open another notebook to see how to code this.


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:46Z
----------------------------------------------------------------

this cell is an extra detail that doesn't add much value


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:47Z
----------------------------------------------------------------

no need to define the learning rate as it's default?


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:48Z
----------------------------------------------------------------

exclude the first 10 epochs?


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:49Z
----------------------------------------------------------------

use scanpy


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:50Z
----------------------------------------------------------------

use scanpy


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:50Z
----------------------------------------------------------------

can you explain why one should use uniform or importance? Can you compare the two results head to head? Perhaps uniform has a lot of lowly expressed bad genes as top hits?


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:51Z
----------------------------------------------------------------

better y axis name so we don't confuse with p values


@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2023

View / edit / reply to this conversation on ReviewNB

adamgayoso commented on 2023-05-16T21:31:52Z
----------------------------------------------------------------

it's not cpm. I'd remove target sum as median is better anyway and remove the comment.


Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rerun it so the outputs are there?

@martinkim0 martinkim0 linked an issue May 22, 2023 that may be closed by this pull request
@adamgayoso adamgayoso merged commit 01f70be into main May 25, 2023
@adamgayoso adamgayoso deleted the lvmde-update branch May 25, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lvm-DE notebook

3 participants