Skip to content

Conversation

@martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented May 31, 2023

Formatting

  • My tutorial has only one top-level (#) header

Reproducibility

  • My tutorial works on Google Colab
  • My tutorial sets scvi.settings.seed = 0 at the beginning of the notebook
  • My tutorial has been run and includes outputs (e.g. plots, tables)

Other

  • Counts and normalized data should co-exist in the datasets, see the API overview for an example
  • For scRNA-seq data, normalization should be counts per median library size and then log1p transformed -- if not, a reason should be given

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@martinkim0 martinkim0 changed the title Run scbasset with motif Add motif scoring to main scbasset tutorial May 31, 2023
@martinkim0
Copy link
Contributor Author

Hi @jacobkimmel, thank you for your original PR. This PR includes your changes in the main scbasset tutorial, I'll add you as an author for this one.

@martinkim0 martinkim0 requested a review from adamgayoso May 31, 2023 18:11
@jacobkimmel
Copy link

awesome, thanks @martinkim0! I did indeed feel a little silly add 10 LOC to the end of the original and making a copy :)

@adamgayoso adamgayoso merged commit 0cd5a5f into main May 31, 2023
@adamgayoso adamgayoso deleted the scbasset-motif branch May 31, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants