- 
                Notifications
    
You must be signed in to change notification settings  - Fork 48
 
MACSima: added reader #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   45.31%   43.68%   -1.63%     
==========================================
  Files          22       23       +1     
  Lines        2143     2353     +210     
==========================================
+ Hits          971     1028      +57     
- Misses       1172     1325     +153     
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 suggestion.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ata-io into macsima-reader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @berombau! And it was a nice sprint today. Ready to merge!
Redo of previous work in #156.
This tries to solve #155.
Lung_adc_demo
Note that now the cycle information is added to a table and that the coordinate systems are named after the dataset.
For the LiverCellAtlas data, it stores all middle cycle nuclei channels in a different image and table.
Parsing of raw data should be another PR. It differs in the handling of metadata for channels and cycles from https://gustaveroussy.github.io/sopa/api/io/#sopa.io.macsima @quentinblampey.
The channel naming is different (
R{cycle} {marker}instead of{marker}{ (duplicate_number if duplicate markers)). I like both styles, so I'll try to add later style as well and add a parameter.