Skip to content

Conversation

@easlinger
Copy link
Contributor

Changed line warning about discrepancy between fovs in labels and images from "raise logger.warning..." to just logger.warning because it causes a type error to "raise" something that doesn't inherit from the base exception class. This is the only instance of using "raise logger.warning" I was able to find in the repo, so I'm assuming this might be a typo.

See issue 272

Changed line warning about discrepancy between fovs in labels and images from "raise logger.warning..." to just logger.warning because it causes a type error to "raise" something that doesn't inherit from the base exception class. This is the only instance of using "raise logger.warning" I was able to find in the repo, so I'm assuming this might be a typo.
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.15%. Comparing base (70f5060) to head (8e679ed).
⚠️ Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/cosmx.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   50.15%   50.15%           
=======================================
  Files          26       26           
  Lines        2660     2660           
=======================================
  Hits         1334     1334           
  Misses       1326     1326           
Files with missing lines Coverage Δ
src/spatialdata_io/readers/cosmx.py 18.93% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato LucaMarconato merged commit 3890c36 into scverse:main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants