Skip to content

Conversation

@LLehner
Copy link
Member

@LLehner LLehner commented May 23, 2023

Add reader for Curio files

@codecov-commenter
Copy link

Codecov Report

Merging #41 (d6a0b81) into main (2407680) will increase coverage by 0.75%.
The diff coverage is 54.34%.

❗ Current head d6a0b81 differs from pull request most recent head 9427c77. Consider uploading reports for the commit 9427c77 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   42.46%   43.22%   +0.75%     
==========================================
  Files          13       14       +1     
  Lines         617      664      +47     
==========================================
+ Hits          262      287      +25     
- Misses        355      377      +22     
Impacted Files Coverage Δ
src/spatialdata_io/readers/curio.py 41.66% <41.66%> (ø)
src/spatialdata_io/__init__.py 100.00% <100.00%> (ø)
src/spatialdata_io/_constants/_constants.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@kevinyamauchi kevinyamauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LLehner ! This LGTM. Sorry about the failing test. This was actually an issue with SpatialData, which I have fixed upstream.

@codecov-commenter
Copy link

Codecov Report

Merging #41 (72da310) into main (2407680) will increase coverage by 0.50%.
The diff coverage is 51.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   42.46%   42.96%   +0.50%     
==========================================
  Files          13       14       +1     
  Lines         617      661      +44     
==========================================
+ Hits          262      284      +22     
- Misses        355      377      +22     
Impacted Files Coverage Δ
src/spatialdata_io/readers/curio.py 36.36% <36.36%> (ø)
src/spatialdata_io/__init__.py 100.00% <100.00%> (ø)
src/spatialdata_io/_constants/_constants.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kevinyamauchi kevinyamauchi merged commit 18d06c1 into scverse:main May 23, 2023
lucas-diedrich pushed a commit to lucas-diedrich/spatialdata-io that referenced this pull request Nov 26, 2024
* Add initial reader

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update api.md

* Fix pre-commit

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants