-
Notifications
You must be signed in to change notification settings - Fork 7
Add shard awareness #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shard awareness #8
Conversation
63fe28d to
e639495
Compare
fe8a65e to
0557788
Compare
655cdb3 to
0ece3de
Compare
0ece3de to
8e71834
Compare
8e71834 to
bc98d1e
Compare
dkropachev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please create a test to check if pool is getting filled with connections when connections are disconnecte or become broken.
e6cf6b0 to
0bfb27c
Compare
42b9fdb to
c49f171
Compare
|
@dkropachev the last commit makes the driver update the sharding info every time it's null and a new connection is opened. This way, we get the right EDIT: from the CI you can see that this is flaky, needs some time to establish the right amount of connections |
bbda5aa to
ef9abf8
Compare
ef9abf8 to
8f862ad
Compare
|
I corrected formatting, but still need support with the things I mentioned here: #8 (comment) |
I think it is good enough, as I mentioned on the call there is one possible case is when node is scaled down, we will address it in a separate PR/issue if it is real one. |
|
@dkropachev I added extra checks in the tests, does it look alright? I would also want to clean up the commits, they got a little bit messy, and then we could merge |
347e7a1 to
a71181c
Compare
Added support for shard awareness:
Fixes: #10 #3