token-aware-policy: drop _tablets_routing_v1 flag #579
+81
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/fix-token-aware-policy-with-tablets
branch
from
98e73a3 to
70cd971
Compare
dkropachev
force-pushed
the
dk/fix-token-aware-policy-with-tablets
branch
from
70cd971 to
ed89df7
Compare
This flag was introduced to check if server supports tablets. As result driver needs to sync it to policy when control connection is established. Which is an unwanted problem. Let's relay on presence of tablets for given table instead, which will not require any syncing.
dkropachev
force-pushed
the
dk/fix-token-aware-policy-with-tablets
branch
from
ed89df7 to
e3db204
Compare
Lorak-mmk
approved these changes
Nov 4, 2025
sylwiaszunejko
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_tablets_routing_v1flag was introduced to check if server supports tablets.As result driver needs to sync it to policy when control connection is established, which is an unwanted problem.
Initial implementation did not sync
_tablets_routing_v1for policies from execution profiles, as result tablets were not working in such case, the policy was always picking replicas from tokenmap.Let's relay on presence of tablets for given table instead, which will not require any syncing.
Fixes: #575
Pre-review checklist
I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.