Add missing dev and optional dependencies #661
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add numpy and objgraph to dev dependencies (used in tests) - Add auth-kerberos optional dependency for GSSAPI authentication
Initialize `count` variable before the for loop to prevent UnboundLocalError when the loop doesn't execute. This follows the same pattern already used in verify_iterator_data().
The `ndarray.newbyteorder()` method was removed in NumPy 2.0. Use `arr.view(arr.dtype.newbyteorder())` instead, which is compatible with both NumPy 1.x and 2.x. This fixes the failing numpy protocol handler integration tests that started running after numpy was added to dev dependencies.
dkropachev
force-pushed
the
fix/missing-dependencies
branch
from
56ed5b3 to
974a7e2
Compare
Lorak-mmk
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
numpyandobjgraphto dev dependencies (required for running some tests)auth-kerberosoptional dependency for GSSAPI authentication supportDetails
Missing Dev Dependencies
numpy: Used intests/integration/standard/test_cython_protocol_handlers.pyobjgraph: Used intests/stress_tests/test_load.pyNew Optional Dependency
auth-kerberos: Documents the optional kerberos/winkerberos packages used for GSSAPI authentication incassandra/auth.py. The code already handles missing imports gracefully via try/except, but documenting them as optional dependencies improves discoverability.