Skip to content

pool: drop per-query connection log#792

Merged
dkropachev merged 1 commit into
scylladb:masterfrom
avikivity:shard-routing-log-demote
Apr 7, 2026
Merged

pool: drop per-query connection log#792
dkropachev merged 1 commit into
scylladb:masterfrom
avikivity:shard-routing-log-demote

Conversation

@avikivity
Copy link
Copy Markdown
Member

The pool module emits a DEBUG log message when selecting a connection for a query.

Emitting a log message for every query is too noisy.

Since Python logging lacks a TRACE level, just remove the log.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

The pool module emits a DEBUG log message when selecting a connection
for a query.

Emitting a log message for every query is too noisy.

Since Python logging lacks a TRACE level, just remove the log.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces debug log noise in the connection pool by removing a per-query DEBUG message emitted when selecting a shard-aware connection, which can be extremely chatty under normal query load.

Changes:

  • Removed the per-query log.debug(...) call in _get_connection_for_routing_key() when a shard-specific connection is chosen.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dkropachev dkropachev merged commit caa98b6 into scylladb:master Apr 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants