pool: drop per-query connection log#792
Merged
Merged
Conversation
The pool module emits a DEBUG log message when selecting a connection for a query. Emitting a log message for every query is too noisy. Since Python logging lacks a TRACE level, just remove the log.
There was a problem hiding this comment.
Pull request overview
This PR reduces debug log noise in the connection pool by removing a per-query DEBUG message emitted when selecting a shard-aware connection, which can be extremely chatty under normal query load.
Changes:
- Removed the per-query
log.debug(...)call in_get_connection_for_routing_key()when a shard-specific connection is chosen.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkropachev
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool module emits a DEBUG log message when selecting a connection for a query.
Emitting a log message for every query is too noisy.
Since Python logging lacks a TRACE level, just remove the log.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.